Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename properties: idfa -> advertisingId, idfv -> developerScopedId #21

Open
baltpeter opened this issue Aug 17, 2023 · 4 comments
Open
Assignees

Comments

@baltpeter
Copy link
Member

Currently, we're using idfa for the Apple IDFA and Google Advertising ID, and ifdv for Apple's IDFV.

In Android 12, Google has introduced a new App set ID (ASID), which is essentially equivalent to the IDFV:

I've already seen this (https://support.singular.net/hc/en-us/articles/360037640812-Server-to-Server-S2S-Integration-Guide#Collecting_and_Sending_the_App_Set_ID_Required_for_Android_12) in the new singular.net adapter I'm working on (#16). For now, I'll mark this as idfv to match the previous usage.

But I propose to rename the two properties to advertisingId and developerScopedId. While that would unfortunately be a breaking change, I think it makes sense and should be less confusing.

@baltpeter
Copy link
Member Author

I will also list the ANDROID_ID under idfv/developerScopedId. According to https://developer.android.com/reference/android/provider/Settings.Secure.html#ANDROID_ID:

On Android 8.0 (API level 26) and higher versions of the platform, a 64-bit number (expressed as a hexadecimal string), unique to each combination of app-signing key, user, and device.

Previously, this would have rather fit under idfa but I think Android 8 is old enough for us to not consider it relevant anymore:

In versions of the platform lower than Android 8.0 (API level 26), a 64-bit number (expressed as a hexadecimal string) that is randomly generated when the user first sets up the device and should remain constant for the lifetime of the user's device.

@baltpeter
Copy link
Member Author

We should also update https://github.com/tweaselORG/tracker-wiki/blob/adee1c563e572787ee7ce26f5ce82c321fb58ad2/i18n/en.json#L97-L98 to include (GAID, or IDFA) and (IDFA, ASID, or ANDROID_ID).

And it might be good to also add docstrings in index.ts, even though I don't think Typedoc will include them in the rendered docs.

@baltpeter
Copy link
Member Author

We should also update tweaselORG/tracker-wiki@adee1c5/i18n/en.json#L97-L98 to include (GAID, or IDFA) and (IDFA, ASID, or ANDROID_ID).

I'm doing that in tweaselORG/tracker-wiki#16.

@zner0L
Copy link
Contributor

zner0L commented May 10, 2024

I think that makes sense. Let's do what you propose.

@baltpeter baltpeter self-assigned this Sep 17, 2024
baltpeter added a commit that referenced this issue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants