Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pkijs with forge #83

Open
zner0L opened this issue May 31, 2023 · 0 comments
Open

Replace pkijs with forge #83

zner0L opened this issue May 31, 2023 · 0 comments

Comments

@zner0L
Copy link
Contributor

zner0L commented May 31, 2023

As we already discussed in #81, pkijs has some bugs and doesn’t properly support PKCS#12, so we should switch over to https://github.com/digitalbazaar/forge. This has some security implications, since forge implemented TLS completely in Javascript instead of relying on the tested and audited webcrypto API. However, since pkijs would require us to implement and maintain significant parts of the crypto ourselves, I think the tradeoff is worth it, especially considering this library is aimed at users who use it with test devices specifically for that purpose, where the security requirements aren’t as high.

See also this communication from the matrix channel:

@zner0L said:

I think using forge might be more secure, even though we'll need to rely on their implementation of TLS.
(instead of openssls’/nodejs’)

@baltpeter said:

I mean, tbh I'm not too concerned about security here. We'll literally be autoinstalling a tweak that disables all SSL verification on the devices and we're encouraging users to keep the default root:alpine password. People really shouldn't be using their test devices for anything serious regardless of this supervision thing (though maybe we should mention that in the READMEs).

@zner0L said:

Yes, but I think the supervision in particular could also be useful for non-jailbroken users, in which case I would like it to be secure enough. Though for now I do agree.

@zner0L zner0L changed the title Replace pkijswith forge Replace pkijs with forge May 31, 2023
zner0L added a commit that referenced this issue Jun 1, 2023
zner0L added a commit that referenced this issue Jun 1, 2023
zner0L added a commit that referenced this issue Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant