Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.9 #316

Merged
merged 1 commit into from
Dec 27, 2020
Merged

Support Python 3.9 #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
continue-on-error: ${{ matrix.experimental }}
strategy:
matrix:
python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "pypy-2.7", "pypy-3.7"]
python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "3.9", "pypy-2.7", "pypy-3.7"]
twisted-version: ["lowest", "latest"]
experimental: [false]

Expand All @@ -72,6 +72,10 @@ jobs:
twisted-version: "trunk"
experimental: true

- python-version: "3.9"
twisted-version: "trunk"
experimental: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this experimental ?

I see that the build is green.

Twisted trunk supports 3.9 on Linux, Windows and macOS.

I did the initial review, but maybe experimental should be renamed to allow_to_fail or 'ok_to_fail` :)

Also, I see that 3.8 with Twisted trunk is also green .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's experimental because it's using Twisted trunk, rather than the latest release. This functions to catch regressions or compatibility issues with Twisted trunk (note that treq.testing uses twisted.test.iosim which is nominally not a public API). There are non-experimental builds for CPython 3.8 and 3.9 with the latest Twisted release.


steps:
- uses: actions/checkout@v2

Expand Down
1 change: 1 addition & 0 deletions changelog.d/305.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support for Python 3.9: treq is now tested with CPython 3.9.
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
]
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[tox]
envlist =
{pypy,py27,py35,py36,py37}-twisted_lowest,
{pypy,pypy3,py27,py35,py36,py37,py38}-twisted_latest,
{pypy3,py35,py36,py37,py38}-twisted_trunk,
{pypy,pypy3,py27,py35,py36,py37,py38,py39}-twisted_latest,
{pypy3,py35,py36,py37,py38,py39}-twisted_trunk,
towncrier, twine, check-manifest, flake8, docs

[testenv]
Expand Down