Added option to fade in new controller #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added options for how to show the new main view controller
| @@ -306,10 +306,35 @@ - (void)setMainViewController:(UIViewController *)mainViewController animated:(B | |||
| [self.containerView addSubview:incomingViewController.view]; | |||
|
|
|||
| incomingViewController.view.frame = self.containerView.bounds; | |||
| incomingViewController.view.transform = CGAffineTransformTranslate(incomingViewController.view.transform, outgoingStartX, 0.0f); | |||
|
|
|||
There was a problem hiding this comment.
Would you mind cleaning up the extra space here?
|
Looks good. Just a couple cleanup comments. |
- Explicit statement of floats for consistency.
Updates per request of twoToasters team
|
Requested changes have been made. Please let me know if you have any further questions. Thanks! |
|
👍 |
jnjosh
pushed a commit
that referenced
this pull request
Jan 3, 2014
Added option to fade in new controller
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love this concept. For the app we're using this in, our UX team preferred a fade-in action to the slide-over action, so I added it as a dev-settable option where the default action is still your original animation. Please let me know if you've got any questions, and thanks for putting this together!