Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing py.typed files #109

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Oct 14, 2023

Fixes #108

We were accidentally copying typeshed/stubs/entry-stubs to dist/entry-stubs-stubs instead of dist/entry-stubs

@srittau
Copy link
Contributor

srittau commented Nov 2, 2023

This change seems fine, although I'm unsure how this fixes #108?

@Avasam
Copy link
Contributor Author

Avasam commented Nov 2, 2023

This change seems fine, although I'm unsure how this fixes #108?

We were copying the py.typed marker file to the wrong location. So it wasn't included in the distribution.

I ran tests locally to 1. see and understand the issue and 2. Ensure this change copies the file to the right location.

@srittau srittau merged commit 214baeb into typeshed-internal:main Nov 2, 2023
3 checks passed
@JelleZijlstra
Copy link
Contributor

Does this mean that some of our uploaded stub packages are missing this file? Should we force a new release for those?

@AlexWaygood
Copy link
Contributor

Stubs packages generally don't need py.typed files. We only started adding them recently to typeshed's packages because we wanted to explicitly mark some of them as partial. So it means the new feature has been broken up till now, but hopefully it'll work from this point onwards

@Avasam
Copy link
Contributor Author

Avasam commented Nov 2, 2023

Does this mean that some of our uploaded stub packages are missing this file? Should we force a new release for those?

The 40 stubs with partial_stub = true in METADATA.toml would be affected. But as @AlexWaygood just mentioned, it wasn't a regression so much as a non-working new feature.

@Avasam Avasam deleted the fix-missing-py.typed branch November 2, 2023 15:44
@JelleZijlstra
Copy link
Contributor

Thanks, makes sense. So we'll just add the correct py.typed file the next time we touch those stubs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partial stubs are missing the partial marker!
4 participants