Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instanceToPlainAsync method to handle promise values #1490

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tafm
Copy link

@tafm tafm commented Mar 25, 2023

Description

Add a new async instanceToPlain method that handles promise values, it uses the original instanceToPain, check recursively all properties, if some propertie is instance of Promise it adds the promise to a tracking list, after all promises resolved the values also are resolved

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #549

@Helveg
Copy link

Helveg commented Sep 19, 2024

@NoNameProvided could you provide feedback on this PR? This is currently the only proposed solution to a highly desired feature. If the original author is no longer available I am willing to follow up on this PR and improve it to a satisfactory solution. 2 questions:

  • Does this PR meet all the requirements set out by you in the original issue description?
  • Are the key points of the implementation correct? That is, is this the way you would want to tackle the problem?

And finally, if we address the review comments, can this feature be merged?

Again, I'm willing to drag this feature across the finish line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

feature: allow awaiting Promises on properties
3 participants