-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thunderbird 60 support #194
Comments
Duplicate of gorhill/uBlock#3698 |
The relevant documentation is: The first document says:
So this suggests that the uBO webextension won't run before TB 63 is available (but additional APIs will probably be necessary). However, it should be possible to make the legacy version compatible. @M-Reimer: I hope this answers your question in the other (locked) thread. I remember that you helped @gorhill in the past to make uBO run in TB. Perhaps you can support him again now? |
This is probably pretty late for me to answer to, but I can confirm that curiosity-seeker was correct in his research, and that the WebExt version of uBO really does work in Thunderbird's beta channel now, such as in 64.0. For those wondering about Thunderbird's stable versions, they traditionally tend to leap seven version numbers at a time. So those who want uBO in Thunderbird before sometime next spring, when v67.0 will be released, will have to change to the beta channel. ——————————————————— The following is partially off-topic, but is important to know for those who use the betas and/or who use lots of extensions: The Thunderbird extensions in general are going through some rough weather, meaning that upgrading to v64 from e.g. v60 or v53 will cause a fair few older extensions to cease working (Examples that struck me hard include Mailbox Alert and Provider for Google Calendar, although certain CalDAV workarounds exists for the latter, which I could talk about on request). So if your Thunderbird installation has loads of extensions, you'll need to consider whether it's the stable channel or the beta channel that supports the most extensions that are important for you. On the other hand, using the beta channel made not only uBO work again, but also Personas Plus. Thus this is a give-and-take situation. |
@DandelionSprout : After reading your post I tested the latest uBO dev release in TB 64. At first glance everything seemed to work: The dashboard and all settings are now accessible - good! But unfortunately, uBO didn't block any network requests, as a matter of fact its logger remained completely empty. So it seems that there is still something missing (an API?) in TB 64. |
Wait till gorhill addresses the issue. |
In Tb64+, uBO will block when loading an http link, like for feed web pages (only use case for http in #messagepane) and show sites in the popup etc. Element blocking doesn't work tho. The url loaded in #messagepane for email and feed summaries is of url scheme mailbox:// so this is likely where a new "soup" may be needed or other such exception, for that content to be blockable. The Tb webextension apis are being very actively developed and enhanced at the moment. (using Tb66 and uBO 1.17.4) |
How do you get Thunderbird Nightly? I downloaded from the Beta channel and the About menu says I have Thunderbird 60.2.1. I don't see a channel for Nightly. |
Thanks, I had just found it after realizing it's probably on FF's ftp site: https://ftp.mozilla.org/pub/thunderbird/nightly/ |
I had downloaded the beta from Thunderbird's official page, which is way behind what I see in the repo. I will first see how uBO's fare in the latest beta. |
My mistake, I typed |
Downloaded 66.0a1, the interface and filter updating seem to work, but the blocking, element picking, keyboard shortcuts doesn't. |
A further note: the url scheme mailbox:// is used for local folders/pop email; there is also imap:// and news:// as the document urls in #messagepane <browser>. Again, blocking works only for http[s]:// urls; you must create a feed account, add something like Planet Mozilla, and double click the message (default config) to load the web page. You can also see blocking work in a content tab but these are very limited; open addons manager, click Get Addons, click a link like 'see all'. Note that tab switching doesn't initiate an update of the button (tabs in Tb are very different from Fx, but I know the browser.tabs api has been hooked up or attempted to be so that web extensions don't have to worry about this difference - the Tb switching notification, TabMonitor, should probably be enhanced in to match Fx). uBO is critical for Tb web content due to Bug 524281, so there would be huge gratitude to have it back. Bugs in Tb should be filed in the webextensions component. Note also Bug 1504475 for content scripts (for element blocking). |
This is not only relevant for feeds but also for HTML mails in which you allow remote content. |
This comment has been minimized.
This comment has been minimized.
Related issues: - uBlockOrigin/uBlock-issues#194 This is a first iteration, which purpose is to merely allow uBO to load properly. Many things are known to not work, quite probably due to the early Thunderbird support of the WebExtensions framework. Permission which had to be removed: - contextMenus Manifest entries which had to be removed: - commands - sidebar_action uBO's webRequest listeners are not being called when loading a feed item in the preview pane, *except* for resources fetched from embedded iframes. uBO appears to function properly when a feed item is opened in its own tab.
@alta88 : I know that. Nevertheless you have to allow remote content from specific domains for various HTML mails (e.g. from tour operators/travel agencies) to make them viewable. Filtering related tracking elements with uBO improves your privacy. |
@gorhill : FYI, the latest info about the available webextension APIs in Thunderbird is here: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I would like to keep the issue strictly for comments which help advance resolution of the issue (technical information, etc.). Anything else is noise and annoying for whoever is following the issue as we receive a notification for every single comment. I will lock the issue if this is not respected. |
I've been testing uBO 1.22.x in the recent days with Thunderbird 68 on Arch Linux. 3 observations:
|
I tried installing the newest uBlock Origin into Thunderbird 60, and this is what i got:
The text was updated successfully, but these errors were encountered: