Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings are difficult to access with a longer list #3058

Closed
9 tasks done
usernamehyphen opened this issue Jan 4, 2024 · 25 comments
Closed
9 tasks done

settings are difficult to access with a longer list #3058

usernamehyphen opened this issue Jan 4, 2024 · 25 comments
Labels
bug Something isn't working Firefox-Android specific to Android platform

Comments

@usernamehyphen
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT an issue with YouTube, Facebook or Twitch.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

When opening settings to get filters cache invalidated and refreshed, my filters tab opens, text area gets focus, scrolls down to its end (possibly because it remebers last focused line?) and hides settings and (the other) filters tabs, scrolling up on page is not possible and so settings and posibility to update external filter lists.

A specific URL where the issue occurs.

localhost

Steps to Reproduce

  1. Set up a long user filter list so its longer than screen (shows scrollbar)
  2. Open unlock origin from any page in fennec(Firefox from f-droid repo)
  3. Open dashboard
  4. Try to navigate to other tabs...

Expected behavior

Being able to get to settings tab

Actual behavior

not being able to get to settings... not really, there is a workaround)

uBO version

1.54

Browser name and version

fennec 121.0.0 (Build #1210020), 1955f8455f+ GV: 121.0-20231221193920 AS: 121.0

Operating System and version

lineageos

@usernamehyphen
Copy link
Author

Scrollbar doesn't even show.
Screenshot_20240104-085903_Fennec edited

@garry-ut99
Copy link

garry-ut99 commented Jan 4, 2024

I can reproduce: Firefox 121 & uBO 1.54, it wasn't happening in some previous versions of Firefox, so it's something which happens in new Firefox versions.

usernamehyphe : not being able to get to settings... not really, there is a workaround

The workaround is to access uBO settings by :
... > Addons > Manage Addons > uBlock Origin > Settings instead of
... > Addons > uBlock Origin > Open Settings Pane

The bug doesn't occur then.

@u-RraaLL u-RraaLL added the Firefox-Android specific to Android platform label Jan 4, 2024
@u-RraaLL
Copy link
Contributor

u-RraaLL commented Jan 4, 2024

Happens only with Scroll to hide toolbar enabled.

(Settings > Customize > Gestures > Scroll to hide toolbar)


@ reply below: Yes, default browser config. Steps to reproduce are an important part of investigating issues. Just FYI.

@usernamehyphen
Copy link
Author

Happens only with Scroll to hide toolbar enabled.

(Settings > Customize > Gestures > Scroll to hide toolbar)

Yes, that is true... however, You could have shorten it to happens only in default settings

@gwarser
Copy link

gwarser commented Jan 4, 2024

Duplicate of #2326 (comment) ?


Ok, it was in comment, let's say this one is about toolbar.

@J3ekir
Copy link

J3ekir commented Jan 4, 2024

I think you should use something like this in 1p-filters.css.
body { height: 100svh; }

@krystian3w
Copy link

krystian3w commented Jan 9, 2024

#3058 (comment) - but for Firefox 101+, so 79–100 need other idea (One rabbi says that the error does not occur in edition 120 and the second rabbi's opinion rather indicates that any edition with a retractable strap address bar may be susceptible).

gorhill added a commit to gorhill/uBlock that referenced this issue Jan 19, 2024
@partingscientist
Copy link

partingscientist commented Feb 12, 2024

Not sure whether this issue is thought to be resolved or not, but I can still reproduce this issue on the latest dev version on mobile.

@gwarser
Copy link

gwarser commented Feb 12, 2024

Not yet in stable build, and it's difficult to test in dev uBO on mobile.

@krystian3w
Copy link

Maybe have rooted device and switched xpi files in profile (as long Firefox itself reject these modification).

@gorhill
Copy link
Member

gorhill commented Feb 29, 2024

No feedback, assuming it is fixed, closing.

@gorhill gorhill closed this as completed Feb 29, 2024
@gwarser gwarser added the bug Something isn't working label Feb 29, 2024
@gwarser
Copy link

gwarser commented Feb 29, 2024

Still broken. Not sure the workaround from #3058 (comment) worked for me before, but it does not work now. My workaround to put cursor in the first line still works.

@gorhill gorhill reopened this Feb 29, 2024
@gorhill
Copy link
Member

gorhill commented Mar 1, 2024

Toggling on desktop mode is also a good workaround.

gorhill added a commit to gorhill/uBlock that referenced this issue Mar 5, 2024
gorhill added a commit to gorhill/uBlock that referenced this issue Mar 5, 2024
@gwarser
Copy link

gwarser commented Mar 5, 2024

Does not work for me.

Redmi Note 10 Pro, b14.

As soon the text cursor is restored to the bottom of the list, menu disappears.

@gorhill
Copy link
Member

gorhill commented Mar 5, 2024

Does not work for me.

Then I don't know what to do. I could reproduce before the change, I can no longer reproduce after the change, and I understand that the issue was because 100vh was used, but 100vh included the browser chrome, while svh exclude the browser chrome -- hence my understanding of why this fixed it on my side.

@partingscientist
Copy link

I can no longer reproduce on Firefox Nightly using the latest dev version. Thought I would share that.

@krystian3w
Copy link

Maybe similar test need list viewer and resource viewer:

  • for first I lost search bar and error counter
  • for viewer I lost input with URL

@garry-ut99
Copy link

The bug in "My filters" pane is fixed for me on 2 different phones.

But like the above comment says - for me the same bug still occurs also in resource viewer
(in "Filter lists" pane after clicking an eye icon to view content of a filter list.)

@gwarser
Copy link

gwarser commented Mar 6, 2024

I have no idea - I tried it this morning, and it magically fixed itself 😕

I was testing it for over an hour now, and all was fine in mobile mode (desktop view still broken for over 100 lines, I have ~200). I even tried reinstalling uBO again (installing from file without disabling uBO from add-on manager does not work - yesterday I installed it after turning it off from add-on manager "just in case").

All was fine!

And just out of the blue I toggled to desktop mode and back and now it's broken again!!!
I even recorded video of reproducing it! (not triggering, just issue visible after accessing the dashboard)

And you know what? It just fixed itself again :D

Must be something very rare or with unique STR, so hopefully users will not have issue with it too often.


I don't have issue with list/resource viewer.

@garry-ut99
Copy link

garry-ut99 commented Mar 6, 2024

gwarser : I don't have issue with list/resource viewer.

Are you sure, because the bug in resource viewer sometimes occurs immediately after opening a list in resource viewer, but sometimes not, but even if it doesn't occur immediately, then still can be reproduced by additional steps, for example in "AdGuard - Mobile Ads", any of the 2 will trigger the bug for me :

  • typing a single letter in the search field (for example "v")
    and waiting a second until it automatically jumps to the found line
  • or clicking down arrow on Errors: 1 found

@gorhill
Copy link
Member

gorhill commented Mar 6, 2024

Out of caution since it's the first time I use svh units, I added the 100svh only for mobile mode in the dashboard. Resource viewer is not embedded in the dashboard, so it needs its own 100svh. I should look up everywhere 100vh is used.

gorhill added a commit to gorhill/uBlock that referenced this issue Mar 6, 2024
@garry-ut99
Copy link

garry-ut99 commented Mar 12, 2024

Fixed for me now in 1.56.1b15.

By the way, I see that "Scroll to hide tollbar toolbar" doesn't work in uBO settings panes, but for example it does work in AdGuard for Browser settings panes, it would be useful to have it supported by uBO.

@gorhill
Copy link
Member

gorhill commented Mar 12, 2024

Scroll to hide tollbar

What's that?

@garry-ut99
Copy link

garry-ut99 commented Mar 12, 2024

I made a typo, I meant "toolbar", not "tollbar", I mean the same setting which was causing the issue here, like mentioned in #3058 (comment).

@krystian3w

This comment was marked as outdated.

@gorhill gorhill closed this as completed Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Firefox-Android specific to Android platform
Projects
None yet
Development

No branches or pull requests

8 participants