Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“My filters” tab isn’t scrollable in higher zoom rate #3211

Closed
9 tasks done
DimitrisKalaboukas opened this issue Apr 15, 2024 · 10 comments
Closed
9 tasks done

“My filters” tab isn’t scrollable in higher zoom rate #3211

DimitrisKalaboukas opened this issue Apr 15, 2024 · 10 comments
Labels
fixed issue has been addressed

Comments

@DimitrisKalaboukas
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

“My filters” tab isn’t scrollable in higher zoom rate (e.g. 150% on Firefox). After the addition of settings above the custom filters’ box in version 1.57.0, you can’t see it with this browser configuration, unless you zoom-out.

A specific URL where the issue occurs.

everywhere

Steps to Reproduce

  1. Open uBO settings
  2. Zoom-in at 150% and above
  3. Go to “My filters” tab

Expected behavior

“My filters” tab is scrollable letting you to scroll down in order to access the custom filters’ box.

Actual behavior

“My filters” tab isn’t scrollable (like other tabs) showing only custom filters’ settings.

uBO version

1.57.2

Browser name and version

Mozilla Firefox 115.9.1esr

Operating System and version

Windows 7 32bit SP1

@gorhill
Copy link
Member

gorhill commented Apr 15, 2024

Unable to reproduce with Firefox 124.0.

Please provide a screenshot to be sure I understand what you are describing.

@DimitrisKalaboukas
Copy link
Author

@gorhill At 100% zoom rate:

1

and at 150% zoom rate:

2

E.g. in "Filter lists" tab it has scrollbar and can also be scrolled by mouse:

3

@gorhill
Copy link
Member

gorhill commented Apr 15, 2024

What is the resolution of your display?

@DimitrisKalaboukas
Copy link
Author

@gorhill 1024x720.

@u-RraaLL
Copy link
Contributor

The issue may be your browser customization. There's supposed to be a "maximize" button on the left of the search box - see if it works even if you can't see it.

I need to zoom by 320% to wholly lose the text box from viewport and even then, using the button works. (But I can't reproduce the search box getting partially hidden like on your screenshot.)

@garry-ut99
Copy link

garry-ut99 commented Apr 15, 2024

1024x720.

Looking at the screenshoots resolution it's 1280x720 (HD), with such resolution + menu toolbar & bookmarks toolbar enabled, I can reproduce the issue at 170% zoom with "text zoom only" feature disabled, a fact that OP can reproduce at 150% zoom, is most likely caused by his additional Windows or Firefox theme modifications.

The issue may be your browser customization. There's supposed to be a "maximize" button on the left of the search box - see if it works even if you can't see it.

The invisible uBO maximize viewport button is caused by Windows 7 "High contrast black" theme: https://www.youtube.com/watch?v=OO8Zqh_FpCo&start=88 but the button is still here and still does work, also browser's maximize/minimize/close buttons becomes flat, like on OP's screenshoots.

@gorhill
Copy link
Member

gorhill commented Apr 15, 2024

I can reproduce when zooming above 300% on my side with a reduced window size. I have a local fix but I need to look more into it to see if this will break in other ways.

@garry-ut99
Copy link

garry-ut99 commented Apr 15, 2024

above 300%

I don't understand why you need so much given I can reproduce at 170% (on both Win 7 SP1 and Win 10 22H2).


OK, I know why I could reproduce at 170%, it's because I also had Windows 7 system DPI scaling set at 125% in Screen options, most likely OP did same too.

But then I double-checked the issue on Windows 10 22H2 without any system scaling modifications to be sure it's not caused by Win 7 system scaling, and I could still reproduce at 170%.

Then it has turned out it's caused by a fact I run Windows 10 22H2 in VM, so it seems VM somehow replicated Win 7 Host 125% system scaling into Windows 10 Guest.

Now I set Win 7 system DPI scaling back to default 100% and I need 240% zoom to reproduce OP's issue.

https://www.techrepublic.com/article/get-a-better-view-in-windows-7-by-adjusting-dpi-scaling/

@DimitrisKalaboukas
Copy link
Author

I need this kind of display setup due to severe visual impairment, as many other people with similar difficulties. My fault, the display resolution I use is really 1280x720 with DPI scaling at 125%. I don’t have issues with any button (I’m aware of dark theme limitations in Windows 7) and my browser is always maximized.

@u-RraaLL
Copy link
Contributor

I don’t have issues with any button

There is a button that should work as a workaround for your issue. You just don't see it. Here:

screen recording
my-filters-maximize.mp4

gorhill added a commit to gorhill/uBlock that referenced this issue Apr 16, 2024
@u-RraaLL u-RraaLL added the fixed issue has been addressed label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants