Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBO tooltips conflicts with browser tooltips (Legacy issue) #63

Closed
8 tasks done
THEtomaso opened this issue Jun 8, 2018 · 6 comments
Closed
8 tasks done

uBO tooltips conflicts with browser tooltips (Legacy issue) #63

THEtomaso opened this issue Jun 8, 2018 · 6 comments
Labels
Firefox-legacy specific to Firefox-legacy variant fixed issue has been addressed

Comments

@THEtomaso
Copy link

THEtomaso commented Jun 8, 2018

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

In Firefox Legacy browsers (e.g. Pale Moon and SeaMonkey), uBO tooltips are placed beneath browser tooltips

Screenshot:

ublockorigin-bug-tooltips

Possible fix?:

If possible, perhaps browser tooltips should be disabled for uBO?
Since all of the browser tooltips only say "uBlock Origin", the only place where it makes sense to keep it is on the toolbar icon itself.

Reference:

https://github.com/uBlockOrigin/uBlock-issues/issues/22/#issuecomment-384240402
I've tried referencing to the post above before, but I think it has gone by unnoticed.

Your environment

  • uBlock Origin version: 1.16.4.1 (XUL)
  • Browser Name and version: Pale Moon v27.9.2,x64
  • Operating System and version: Win8.1Pro,x64
@uBlock-user
Copy link
Contributor

uBlock-user commented Jun 8, 2018

perhaps browser tooltips should be disabled for uBO?

That setting exists already, open the Settings page and put a tick on Disable tooltips.

@uBlock-user uBlock-user added the Firefox-legacy specific to Firefox-legacy variant label Jun 8, 2018
@THEtomaso
Copy link
Author

That setting exists already, open the Settings page and put a tick on Disable tooltips.

No, that disables uBO's tooltips, not browser tooltips.
Of course, there is this setting under the browsers about:config:
browser.chrome.toolbar_tips
..but changing its value will disable all browser tooltips in general.

@gorhill gorhill added the wontfix won't be addressed label Jun 8, 2018
@gorhill
Copy link
Member

gorhill commented Jun 8, 2018

It's a browser issue.

And more generally, I won't spend time on the legacy version except for issues which are worth the time -- serious malfunctions or performance issues. Pull requests done with care are accepted.

@gorhill gorhill closed this as completed Jun 8, 2018
@janekptacijarabaci
Copy link

@gorhill
I suggest adding to:
https://github.com/gorhill/uBlock/blob/firefox-legacy-1.16.4.1/platform/firefox/vapi-background.js#L2697
this line:
toolbarButtonPanel.setAttribute('tooltiptext', '');

If I do not miss something...

gorhill added a commit to gorhill/uBlock that referenced this issue Jun 17, 2018
@gorhill
Copy link
Member

gorhill commented Jun 17, 2018

@janekptacijarabaci Thanks, this worked.

@gorhill gorhill removed the wontfix won't be addressed label Jun 17, 2018
@uBlock-user uBlock-user added the fixed issue has been addressed label Jun 17, 2018
@janekptacijarabaci
Copy link

Thank you also, @gorhill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firefox-legacy specific to Firefox-legacy variant fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants