generate unique id using timestamp + random bits #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SeeratSek
commented
May 25, 2018
SeeratSek
commented
- used rs/xid package (https://blog.kowalczyk.info/article/JyRZ/generating-good-unique-ids-in-go.html)
- change Players to use id as key
- players with same name can now play concurrently
- used rs/xid package - change Players to use id as key - players with same name can now play concurrently
teelau
reviewed
May 25, 2018
| @@ -61,6 +64,11 @@ func CreatePlayer(n string, p Position, c string, ws *websocket.Conn) *Player { | |||
| } | |||
| } | |||
|
|
|||
| func GenUniqueID() string { | |||
| id := xid.New() | |||
There was a problem hiding this comment.
Very cool indeed. Was this package added using dep? The Gopkg.toml file should have been updated
There was a problem hiding this comment.
soo I imported the package before calling dep -add and now i'm having trouble doing dep -add after the fact.. (golang/dep#1670). I can just manually update the Gopkg.toml file with the constraint right?
There was a problem hiding this comment.
Sure! Try that and when you update, I'll pull this branch and try running dep ensure to see if it works
teelau
previously approved these changes
May 25, 2018
Pull Request Test Coverage Report for Build 138
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.