Remove hardcoded file ignore string check #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean by "most linter drivers, especially nogo, are now able to respect |
Rephrased the PR decription 👍 |
yuxincs
force-pushed
the
yuxincs/remove-hardcoded-file-ignore-string-check
branch
from
b6391b7
to
92dced1
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
1bb9133
to
717021a
Compare
yuxincs
force-pushed
the
yuxincs/remove-hardcoded-file-ignore-string-check
branch
2 times, most recently
from
e5deadf
to
2d16cfe
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
64b66ac
to
2a06f68
Compare
yuxincs
force-pushed
the
yuxincs/remove-hardcoded-file-ignore-string-check
branch
from
2d16cfe
to
c265f5b
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
2 times, most recently
from
f665ba1
to
7456a3b
Compare
yuxincs
force-pushed
the
yuxincs/remove-hardcoded-file-ignore-string-check
branch
from
c265f5b
to
6c21883
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
7456a3b
to
e92f4de
Compare
yuxincs
force-pushed
the
yuxincs/remove-hardcoded-file-ignore-string-check
branch
2 times, most recently
from
b07ae5d
to
eb66fc4
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
e92f4de
to
6990af9
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
6990af9
to
d6e0736
Compare
yuxincs
force-pushed
the
yuxincs/remove-hardcoded-file-ignore-string-check
branch
from
eb66fc4
to
c725ec0
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
d6e0736
to
fe2b512
Compare
yuxincs
force-pushed
the
yuxincs/remove-hardcoded-file-ignore-string-check
branch
2 times, most recently
from
1ce63c1
to
42256c8
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
fe2b512
to
4db2508
Compare
yuxincs
force-pushed
the
yuxincs/remove-hardcoded-file-ignore-string-check
branch
from
42256c8
to
6a44aa6
Compare
yuxincs
force-pushed
the
yuxincs/remove-hardcoded-file-ignore-string-check
branch
from
6a44aa6
to
d5a242f
Compare
sonalmahajan15
pushed a commit
that referenced
this pull request
Aug 5, 2023
This PR removes the hardcoded `nolint:nilaway` docstring check for both files and function declarations since it is no longer necessary: * files: we have implemented configuration analyzer in #9 which is able to take a list of strings to ignore the analysis of a file. * function declaration: it is mainly designed for two reasons: * performance: we were able to use it to manually skip the analysis of a particular function for performance reasons. However, we now have a timeout for analysis of any particular function, hence this is no longer required. * error suppression: most linter drivers, especially nogo, are now respecting `nolint`, so there is really no need to support it within the linter itself. Depends on #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded
nolint:nilawaydocstring check for both files and function declarations since it is no longer necessary:files: we have implemented configuration analyzer in Add a NilAway config analyzer for parsing and sharing configurations #9 which is able to take a list of strings to ignore the analysis of a file.
function declaration: it is mainly designed for two reasons:
nolint, so there is really no need to support it within the linter itself.Depends on #10