Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new x/tools dep to work with newer go1.23.0 #270

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

jayalane
Copy link
Contributor

As per issue #269 this PR updates go.mod/go.sum to work with go 1.23.0

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2024

CLA assistant check
All committers have signed the CLA.

@jayalane jayalane mentioned this pull request Aug 14, 2024
@jayalane jayalane changed the title anew x/tools dep to work with newer go1.23.0 new x/tools dep to work with newer go1.23.0 Aug 14, 2024
@arnested
Copy link

I experience the same problem and this fixes it for me as well.

@yuxincs
Copy link
Contributor

yuxincs commented Aug 15, 2024

@jayalane , would you mind signing the CLA? Happy to merge the PR once CLA is signed 😃

Thank you for the contributions!

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (58a288b) to head (2b4e65a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files          63       63           
  Lines        7916     7916           
=======================================
  Hits         6935     6935           
  Misses        799      799           
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chlanejayasinha
Copy link
Contributor

Signed. (I had signed it at the time but I put in a different email that I thought was associated to the account but wasn't; just now I signed it with an email that was associated to the account).

@chlanejayasinha
Copy link
Contributor

The failing test looks like it succeeded but then failed to connect back to api.github.com with the results. 403. a

@yuxincs
Copy link
Contributor

yuxincs commented Aug 21, 2024

The failing test looks like it succeeded but then failed to connect back to api.github.com with the results. 403. a

Yeah it's because the GITHUB_TOKEN in forked repository doesn't have permission to post comments for security reasons. We have fixed this in #273 . I'll update your branch to have the latest changes, and merge once CI passes

Copy link

Golden Test

Note

✅ NilAway errors reported on standard libraries are identical.

3271 errors on base branch (main, 58a288b)
3271 errors on test branch (e065d49)

@yuxincs
Copy link
Contributor

yuxincs commented Aug 21, 2024

Thanks @jayalane!

@yuxincs yuxincs merged commit 56f5ac5 into uber-go:main Aug 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants