Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break assume return into a separate hook in the generalized hook framework #279

Open
wants to merge 3 commits into
base: yuxincs/generalize-hook
Choose a base branch
from

Conversation

yuxincs
Copy link
Contributor

@yuxincs yuxincs commented Sep 16, 2024

This PR refactors the logic that returns nonnil producer in the new generalized hook framework into a new strongly-typed hook for better maintainability and slightly better performance (fewer look ups in all hook points). It introduces no functionality changes.

@yuxincs yuxincs marked this pull request as ready for review September 16, 2024 03:50
@yuxincs yuxincs changed the title Break assume return into a separate sub-hook in the generalized hook framework Break assume return into a separate hook in the generalized hook framework Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (6884546) to head (10acb30).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           yuxincs/generalize-hook     #279   +/-   ##
========================================================
  Coverage                    87.60%   87.61%           
========================================================
  Files                           63       64    +1     
  Lines                         7916     7922    +6     
========================================================
+ Hits                          6935     6941    +6     
  Misses                         799      799           
  Partials                       182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 16, 2024

Golden Test

Note

✅ NilAway errors reported on standard libraries are identical.

3271 errors on base branch (yuxincs/generalize-hook, 6884546)
3271 errors on test branch (a2e8614)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant