Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create basic unit tests for library model generation #1031

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Sep 6, 2024

This is in preparation for #1006. When working on that PR I realized we really need some unit tests to more easily debug various scenarios (right now all we have are integration tests). Plus this will make our code coverage reports more useful. This adds some infrastructure for unit tests and a couple of basic tests; we will add more as we go. Also fix a couple minor issues in LibraryModelGenerator.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.28%. Comparing base (b7756ea) to head (fdd57b6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../uber/nullaway/libmodel/LibraryModelGenerator.java 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1031      +/-   ##
============================================
+ Coverage     86.06%   87.28%   +1.21%     
- Complexity     2110     2117       +7     
============================================
  Files            83       83              
  Lines          6932     6943      +11     
  Branches       1344     1346       +2     
============================================
+ Hits           5966     6060      +94     
+ Misses          550      456      -94     
- Partials        416      427      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar marked this pull request as ready for review September 6, 2024 00:37
@msridhar msridhar merged commit fe9476a into uber:master Sep 6, 2024
11 checks passed
@msridhar msridhar deleted the library-model-gen-unit-tests branch September 6, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants