Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Error Prone 2.20.0 #772

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Update to Error Prone 2.20.0 #772

merged 2 commits into from
Jun 23, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Jun 22, 2023 •
edited
Loading

Pretty straightforward update. No urgency to land

@coveralls
Copy link

coveralls commented Jun 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build #1120

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 92.773%
Files with Coverage Reduction New Missed Lines %
../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java 2 95.79%
Totals Coverage Status
Change from base Build #1119: -0.02%
Covered Lines: 5610
Relevant Lines: 6047
💛 - Coveralls

lazaroclapp
lazaroclapp approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Let's not forget to change the configured jobs before landing (but not sure if we are landing some of the others before, so not doing that now)

@msridhar msridhar enabled auto-merge (squash) June 23, 2023 23:07
@msridhar msridhar merged commit 18b6ab3 into master Jun 23, 2023
7 checks passed
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 18, 2023
@msridhar
Revert "Update to Error Prone 2.20.0 (uber#772)"
50169ab 
This reverts commit 18b6ab3.
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 18, 2023
@msridhar
Revert "Update to Error Prone 2.20.0 (uber#772)"
7a08a64 
This reverts commit 18b6ab3.
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 19, 2023
@msridhar
Revert "Update to Error Prone 2.20.0 (uber#772)"
b94fa62 
This reverts commit 18b6ab3.
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 19, 2023
@msridhar
Revert "Update to Error Prone 2.20.0 (uber#772)"
d39f37a 
This reverts commit 18b6ab3.
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 19, 2023
@msridhar
Revert "Update to Error Prone 2.20.0 (uber#772)"
182a900 
This reverts commit 18b6ab3.
@msridhar msridhar deleted the ep-2.20.0 branch September 4, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazaroclapp lazaroclapp lazaroclapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msridhar @coveralls @lazaroclapp