Adding support for Robolectric 4.7.3 and preinstrumented jars #958
Conversation
| @@ -115,9 +118,10 @@ public void finalizeDependencies(OkBuckExtension okBuckExtension) { | |||
| API_25("7.1.0_r7", "r1"), | |||
| API_26("8.0.0_r4", "r1"), | |||
| API_27("8.1.0", "4611349"), | |||
| API_P("P", "4651975"), | |||
There was a problem hiding this comment.
https://github.com/robolectric/robolectric/blob/master/robolectric/src/main/java/org/robolectric/plugins/DefaultSdkProvider.java No longer referenced in robolectric core.
| String getCoordinates() { | ||
| return "org.robolectric:android-all:" | ||
| String getCoordinates(String preinstrumentedVersion) { | ||
| return "org.robolectric:android-all-instrumented:" |
There was a problem hiding this comment.
we can return the old format and new preinstrumentedVersion based on if preinstrumentedVersion is null or not.
This will keep it backward compatible.
There was a problem hiding this comment.
We can, but this is now hardcoded in robolectric 4.7 so there's also a reason to require it and default to i3 (the default version checked in at this time). Thoughts on keeping backwards compatibility with older robo versions instead of a sane default?
There was a problem hiding this comment.
sounds good then. We can ask users to upgrade to latest robolectric in the release notes.
Master is currently not in state to release a new version of OKbuck without reverting the work towards upgrading Gradle.
I've created a release branch off of the last tag (v0.52.3) and this is a pull request against that branch. We can cut this release build 0.52.4 from the release branch, then separately patch this diff against master which will require some rebase conflict changes.
This was tested locally against the Uber Android monorepo.
-4.7.3 is needed to address ARM compatibility on m1, as it carries a patch for sqlite4java.
-They also introduced preinstrumented jars which should save 10-12 seconds per test process instantiation.