Update to Android tools v30.3.0 #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyvsmith
reviewed
Apr 2, 2024
.buckconfig
Outdated
| @@ -25,6 +25,10 @@ | |||
| [java] | |||
| jar_spool_mode = direct_to_jar | |||
| duplicates_log_level = fine | |||
| compile_against_abis = false | |||
There was a problem hiding this comment.
the plugin works in monorepo but okbuck tests are failing due to ASM in Buck trying to perform the class ABI on a java 17 class from a dependency. i'm working on a better fix
build.gradle
Outdated
| @@ -1,7 +1,14 @@ | |||
| buildscript { | |||
| apply from: rootProject.file("dependencies.gradle") | |||
| repositories { | |||
| google() | |||
| maven { | |||
| url 'https://dl.google.com/android/maven2/' | |||
There was a problem hiding this comment.
due to rocker and other breaking upgrades since we are on AGP 4.x, we need to set the property of the maven url to use pom instead of gradle metadata & ---we can't do this w/ google--- n/m, actually we can, so updated
jbarr21
force-pushed
the
jb/lint-31
branch
2 times, most recently
from
b45630e
to
a911929
Compare
jbarr21
changed the title
tyvsmith
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Android tools version to allow for using Lint v31.3.1 or higher which is compatible with K2. Repos can choose their lint version, but to use a newer version, they need to use a compatible manifest merger version which had some breaking changes in v30.3.0.
A bump to Kotlin v1.5 was needed due to compatibility with transitive dependencies. Along the way, the sample project needed to be updates such as removing deprecated kotlin-extensions, disabling unused lints, & backporting removed methods.