Hyperbahn client #87
Merged
Hyperbahn client #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.error(service + " failed to advertise. " + ex.getMessage()); | ||
| } | ||
| } | ||
| }, advertiseInterval); |
There was a problem hiding this comment.
Wasn't the requirement to not have a fixed advertiseInterval and change the internval depending if the advertise response is a success or a failure ?
There was a problem hiding this comment.
AdvertiseInterval is fixed (1 min). Only retry on failure should back off.
We don't really have retry on failure yet ...
|
lgtm |
Implement very basic HyperbahnClient. Fix bug in MessageFragmenter where we weren't writing out the TTL from the Outbound Request. Add a basic hyperbahn example to tchannel-example. Add back loading routers from disk Fix null header bug! Cleanup timeouts Fix naming of request handlers in tchannel-example *somebody* was overly aggressive with their class refactoring :) Rebase on master. Tests may fail due to missing hosts file
fix the review comments
ShanniLi
force-pushed
the
hyperbahn-client
branch
from
975ba5a
to
5e88331
Compare
|
@truncs Need to move forward to unblock others. Feel free to create issues on me for improvements. I will be happy to fix them along the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r @willsalz @truncs @anson627 @junchaoWu
In this PR, tchannel-java can advertise to Hyperbahn and serve requests.
Next steps: