Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update godot logo URL #694

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

Jeffrey04
Copy link
Contributor

I am seeing some errors while trying to install godot through ubuntu-make saying the logo URL does not exist, so I am submitting this PR. Not sure if this is going to completely fix the problem though. Do let me know if there are other things I need to include as part of the PR.

@Jeffrey04
Copy link
Contributor Author

Jeffrey04 commented May 23, 2024

seems to work, but in my test virtualenv i am getting a git error, as shown below

jeffrey04@nobita-ubuntu:ubuntu-make on  update-godot-logo:master [!⇡] via 🐍 v3.12.3 (env) [I]  ./bin/umake games godot
Godot is already installed on your system, do you want to reinstall it anyway? [Yes (y)/No (N)] y
Choose installation path: /home/jeffrey04/.local/share/umake/games/godot
Downloading and installing requirements                                                                                                                                                                                                                                        |
100% |#########################################################################################################################################################################################################################################################################|
Installing Godot
fatal: No names found, cannot describe anything.                                                                                                                                                                                                                               |
|##############################################################################################################################################################################################################################################################################|
Installation done

but otherwise everything seems to work fine, godot is installed, icon is showing up in launcher

@Jeffrey04 Jeffrey04 marked this pull request as ready for review May 23, 2024 18:20
@LyzardKing LyzardKing self-assigned this May 25, 2024
@LyzardKing
Copy link
Collaborator

Thanks @Jeffrey04
I'll look at the error and merge

@Jeffrey04
Copy link
Contributor Author

thanks for the help

@LyzardKing
Copy link
Collaborator

I can't reproduce this issue, so I'll merge for now and we can revisit it if it breaks something in the future.

@LyzardKing LyzardKing merged commit 8c0eb6a into ubuntu:master May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants