Skip to content

Commit

Permalink
warning #128: Update mod_form.php to add completion rules with suffix…
Browse files Browse the repository at this point in the history
… based on branch version
  • Loading branch information
SergioComeron committed Aug 29, 2024
1 parent 21d020e commit 84df295
Showing 1 changed file with 21 additions and 8 deletions.
29 changes: 21 additions & 8 deletions mod_form.php
Original file line number Diff line number Diff line change
Expand Up @@ -150,19 +150,25 @@ public function definition() {
* @return array List of added element names, or names of wrapping group elements.
*/
public function add_completion_rules() {
global $CFG;
if ($CFG->branch < 403) {
$suffix = '';
} else {
$suffix = $this->get_suffix();
}

$mform =& $this->_form;

$group = [
$mform->createElement('checkbox', 'completionminutesenabled', ' ', get_string('completionminutesex', 'jitsi')),
$mform->createElement('text', 'completionminutes', ' ', ['size' => 3]),
$mform->createElement('checkbox', 'completionminutesenabled'.$suffix, ' ', get_string('completionminutesex', 'jitsi')),
$mform->createElement('text', 'completionminutes'.$suffix, ' ', ['size' => 3]),
];
$mform->setType('completionminutes', PARAM_INT);
$mform->addGroup($group, 'completionminutesgroup', get_string('completionminutes', 'jitsi'), [' '], false);
$mform->addHelpButton('completionminutesgroup', 'completionminutes', 'jitsi');
$mform->disabledIf('completionminutes', 'completionminutesenabled', 'notchecked');
$mform->setType('completionminutes'.$suffix, PARAM_INT);
$mform->addGroup($group, 'completionminutesgroup'.$suffix, get_string('completionminutes', 'jitsi'), [' '], false);
$mform->addHelpButton('completionminutesgroup'.$suffix, 'completionminutes', 'jitsi');
$mform->disabledIf('completionminutes'.$suffix, 'completionminutesenabled', 'notchecked');

return ['completionminutesgroup'];
return ['completionminutesgroup'.$suffix];
}

/**
Expand All @@ -172,7 +178,14 @@ public function add_completion_rules() {
* @return bool True if one or more rules is enabled, false if none are.
*/
public function completion_rule_enabled($data) {
return (!empty($data['completionminutesenabled']) && $data['completionminutes'] != 0);
global $CFG;
if ($CFG->branch < 403) {
$suffix = '';
} else {
$suffix = $this->get_suffix();
}

return (!empty($data['completionminutesenabled'.$suffix]) && $data['completionminutes'.$suffix] != 0);
}

/**
Expand Down

0 comments on commit 84df295

Please sign in to comment.