Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uisref on param changing, not only state #976

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oBusk
Copy link
Contributor

@oBusk oBusk commented Jan 11, 2023

If you have a link where some of the params are inherited, they will become outdated if the params change without the state changing.

@@ -129,6 +130,7 @@ export class UISref implements OnChanges {
this._parent = parent;

this._statesSub = _router.globals.states$.subscribe(() => this.update());
this._statesSub = _router.globals.params$.subscribe(() => this.update());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was supposed to be _paramsSub

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was definitely my intention 😅 Fixed it! (0ebf4c1)

@oBusk
Copy link
Contributor Author

oBusk commented Jan 14, 2023

@wawyed When I looked at the code to fix the typo got me thinking if it's unecessary to update the sref twice in the scenario where you switch state and params? Maybe it'd work better if we were to listen to onSuccess or something rather than subscribing to state$ and params$ separately? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants