Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useMap Typing #287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

faizanu94
Copy link

This PR updates the type signature of the useMap function to improve type safety as reference in #278 By specifying separate generic types for keys and values (K and V), we ensure that the useMap hook is more accurately typed

This PR updates the type signature of the useMap function to improve type safety. By specifying separate generic types for keys and values (K and V), we ensure that the useMap hook is more accurately typed
@@ -188,7 +188,7 @@ declare module "@uidotdev/usehooks" {
options?: LongPressOptions
): LongPressFns;

export function useMap<T>(initialState?: T): Map<T, any>;
export function useMap<K, V>(initialState?: Map<K, V>): Map<K, V>;
Copy link

@kj-fiddler kj-fiddler May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for backwards compatibility, we can probably have <K, V = any>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants