Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String dump with correct escaping #244

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

comodoro
Copy link

This pull request is not complete and there are things that require clarification:

  • It passes tests except for test_bug_148 which I do not understand since it seems to test exactly opposite behavior to the one in the issue

  • It may be easy to add an option to dump to multiline as well as escaping or not escaping all Unicode

When complete should fix #201 and indeed #148, related to #236

Reference used: https://github.com/toml-lang/toml#user-content-string

@roedoejet
Copy link

Any reason why this hasn't been merged already?

@comodoro
Copy link
Author

comodoro commented Mar 1, 2020

As far as I remember, it is not complete for all cases and this PR explores the maintainer's attitude. It was started because of issues that surfaced in the Caster project and was not worked upon because of no response here which resulted in a switch to tomlkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect string escaping in TOML encoder
2 participants