-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Angular 15 #398
chore: update to Angular 15 #398
Conversation
Nice, thank you for the PR @Yberion. Will review it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just want to know why we are using legacy material component
@@ -1,8 +1,8 @@ | |||
import { LayoutModule } from '@angular/cdk/layout'; | |||
import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing'; | |||
import { MatButtonModule } from '@angular/material/button'; | |||
import { MatLegacyButtonModule as MatButtonModule } from '@angular/material/legacy-button'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to use mdc based components? I know we don't provide CSS out of the box, but may break the user app if they have some :ng-deep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://material.angular.io/guide/mdc-migration there is a migration guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is harder for people to migrate to MDC as it require quite a lot of CSS update.
If people were customizing your components, it would be easier for them if you don't switch for MDC yet.
Maybe you can do 2 versions, one without MDC (7.0.0) and one with MDC (7.1.0) ?
Up to you, do I migrate this PR to use MDC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it in next PR
Awesome, I will prepare the MDC PR. |
BTW just release V7 with Angular 15 changes |
Yeah I noticed, thank you for that 😊 |
Hello,
This PR does:
typescript
@types/node
^15
browserlistrc
was removednpx browserslist --update-db
to updatecaniuse-lite
environment
files have been deletedangular.json
was update to reflect thatscss
files in the prettieresbuild
@angular-devkit/build-angular:browser
to@angular-devkit/build-angular:browser-esbuild
Feel free to also remove other PR/branche related to packages update for cleaning purpose.
If everything is ok, I can make a new commit to bump the version.
Could you release a new version following this PR? (This would be much appreciated heh)
Have a good day.
cc @santoshyadavdev