Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Related to #437
I've spotted some problems that appeared with the migration to nx.
Since you are now using nx and
@nrwl/angular:package
, when you build the lib, it will add all "used" detected dependencies in the builtpackage.json
.Resulting to something similar to this in
package.json
(and fixed version numbers):There is unused deps and fixed versions.
If we want to prevent nx from adding all detected deps automatically, we need to setup
"updateBuildableProjectDepsInPackageJson": false
in theproject.json
of the lib.However, since it added all used deps in the built version, we can notice that there is some missing
peerDependencies
in non-builtpackage.json
.Diving in the code, I also noticed that hammerjs isn't loaded if we don't need it, that's why I choose to put it in
optionalDependencies
.The final deps in the non-built
package.json
:(Not related to the lib, but the repo)
I also detected by running
npm install
thatzone.js
0.12.0
seems not supported with@storybook/angular@6.5.16
resulting to this:I changed the version to
0.11.4
which is compatible withAngular
^15.2.0
and@storybook/angular@6.5.16
.cc @santoshyadavdev