Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README.md #440

Merged
merged 1 commit into from
Apr 16, 2023
Merged

chore: update README.md #440

merged 1 commit into from
Apr 16, 2023

Conversation

arturovt
Copy link
Collaborator

We explicitly import hammerjs in the code through the dynamic import so this cannot be an optional dependency.

@nx-cloud
Copy link

nx-cloud bot commented Apr 16, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 868feff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@santoshyadavdev santoshyadavdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you. The plan is to drop hammerjs in future.

Meanwhile this is required.

@santoshyadavdev santoshyadavdev merged commit b4d2d98 into uiuniversal:master Apr 16, 2023
@arturovt arturovt deleted the chore/readme branch April 16, 2023 16:43
@Yberion
Copy link
Contributor

Yberion commented Apr 18, 2023

Hello @arturovt, if we set touch to false it should not load it since it's a dynamic import, meaning that we installed that dependencie for nothing if we don't need touch, maybe I'm wrong ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants