Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add Angular 17 support & update packages #477

Merged
merged 24 commits into from
Nov 26, 2023
Merged

build: add Angular 17 support & update packages #477

merged 24 commits into from
Nov 26, 2023

Conversation

Yberion
Copy link
Contributor

@Yberion Yberion commented Nov 18, 2023

Hello @santoshyadavdev,

This PR fixes #476.

What I did:

  • I couldn't use yarn at all this time, I switched to npm (even after everything was updated with npm and switching back to yarn)
  • I updated all packages to latest versions (except jasmine-core)
  • The nx cache is now located in the root folder of the repo, I added .nx in .gitignore
  • There was some problem with how the tsconfigs were done, I fixed all of them (it was causing problems with nx migrations)
  • I applied the migrations from nx
  • I migrated ngu-carousel-example to use the new control-flow
    • I did not update the README.md
  • I removed the cypress component testing config from ngu-carousel-example as it was more or less useless
  • I fixed errors found by the linter
  • I fixed unit tests
  • I removed updateBuildableProjectDepsInPackageJson from ngu-carousel as it was deprecated
    • removing it keeps the same behavior as if it was enable, that's what we want
  • I added missing tsconfig.json (cypress) in the .eslintrc.json of ngu-carousel
  • I updated the current SSR setup
  • I cleaned polyfills usage
  • I updated the CI setup
    • Angular supports node starting version 18.13.0, the CI now runs on ['18.13.0', '20']
    • Updated to actions/checkout@v4 & actions/setup-node@v4
    • Updated to use npm
  • I bumped ngu-carousel for Angular 17
  • I bumped ngu-carousel to 9.0.0 and I updated README.md

TODO on your side:

  • Release a new major version 9.0.0
  • Close branches related to package update

Tell me if everything looks ok for you.

Have a nice day.

Copy link

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments !

libs/ngu/carousel/src/test.ts Outdated Show resolved Hide resolved
apps/ngu-carousel-example/project.json Outdated Show resolved Hide resolved
libs/ngu/carousel/src/test.ts Outdated Show resolved Hide resolved
@santoshyadavdev
Copy link
Member

There is a build error.

@Yberion
Copy link
Contributor Author

Yberion commented Nov 26, 2023

Hello @santoshyadavdev, the build error seemed to be a problem on netlify's side.

The new pipeline looks fine.

@santoshyadavdev
Copy link
Member

Thank you @Yberion I have updated the node version it was old, I will run the pipeline again to check.

@santoshyadavdev santoshyadavdev merged commit 302ff23 into uiuniversal:master Nov 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Angular 17
4 participants