Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use signals everywhere #503

Merged
merged 1 commit into from
Jul 27, 2024
Merged

refactor: use signals everywhere #503

merged 1 commit into from
Jul 27, 2024

Conversation

sheikalthaf
Copy link
Collaborator

@sheikalthaf sheikalthaf commented Jun 22, 2024

  • use signals for input, queries, output
  • use inject function for deps
  • make public Api's signal based (breaking change, required for zoneless support)

It is a followup PR #502

closes #482

Copy link

nx-cloud bot commented Jun 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9a66eaa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@sheikalthaf
Copy link
Collaborator Author

@santoshyadavdev can you review this PR,

we can switch to Angular signals and release it as part of 18

Copy link
Member

@santoshyadavdev santoshyadavdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, BTW I wanted to ask how can we drop hammerjs?

@sheikalthaf
Copy link
Collaborator Author

Yes, we can drop it by using our own drag events. I'll plan to remove it.

@sheikalthaf sheikalthaf merged commit a12533a into master Jul 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel arrow buttons position oddly when slides have buttons present and user tabs using keyboard.
2 participants