Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy>=1.23.0,<2.0.0 #14018

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jun 26, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated version constraint for the numpy dependency to ensure compatibility.

πŸ“Š Key Changes

  • Adjusted the numpy version requirement from >=1.23.5 to >=1.23.0.

🎯 Purpose & Impact

  • Purpose: Fix compatibility issues that were previously encountered with numpy.
  • Impact: This change ensures the software works smoothly with a wider range of numpy versions, minimizing potential conflicts for users. πŸ“ˆ

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 70.28%. Comparing base (69cfc8a) to head (69fc5db).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14018      +/-   ##
==========================================
+ Coverage   70.25%   70.28%   +0.03%     
==========================================
  Files         124      124              
  Lines       15903    15903              
==========================================
+ Hits        11173    11178       +5     
+ Misses       4730     4725       -5     
Flag Coverage Ξ”
Benchmarks 35.81% <100.00%> (+0.03%) ⬆️
GPU 36.89% <100.00%> (ΓΈ)
Tests 66.52% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@glenn-jocher glenn-jocher changed the base branch from main to glenn-jocher-patch-2 June 26, 2024 18:18
@glenn-jocher glenn-jocher merged commit b5e1716 into glenn-jocher-patch-2 Jun 26, 2024
12 of 13 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch June 26, 2024 18:18
Copy link

@VelDia VelDia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned the dependencies of super_gradients and ultralytics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Libraries misalignment in ultralytics and super_gradients required for model YOLO-NAS
2 participants