Parsing User Error for InvalidToken #21
Conversation
adjivas
commented
May 18, 2018
•
adjivas
commented
- Lexer captures InvalidToken and parser returns it as a error.
- Positions can now be implemented by @l and @r tokens at Lalrpop Report errors during Telamon-gen parsing #5 .
- The F/lex FFI part of lexer is now more documented.
- The token position is now checked and implemented from the Lexer grammar.
… end of all inputs, this need a investigation to found another syntax
…efault lexer will be used
…ges like parser test
Cargo.toml
Outdated
| @@ -4,6 +4,7 @@ build = "build.rs" | |||
| name = "telamon" | |||
| readme = "README.md" | |||
| version = "0.2.0" | |||
| autoexamples = true | |||
There was a problem hiding this comment.
That a confusion about the issue 5330, travis repport a warning for a unused manifest key package.autoexamples but that not same on my configuration.
I recommend to remove this line, that probably not more needed and I have solved the example at 74f6990bdeb67bcef425ed0314a875776049f32f
| @@ -180,8 +180,27 @@ typedef size_t yy_size_t; | |||
| #define EOB_ACT_END_OF_FILE 1 | |||
There was a problem hiding this comment.
Can you move this file into src/ ?
telamon-gen/src/bin/cli_gen.rs
Outdated
| @@ -4,5 +4,5 @@ extern crate env_logger; | |||
|
|
|||
| fn main() { | |||
| env_logger::init(); | |||
| telamon_gen::process(&mut std::io::stdin(), &mut std::io::stdout(), true); | |||
| telamon_gen::process(&mut std::io::stdin(), &mut std::io::stdout(), true).unwrap(); | |||
There was a problem hiding this comment.
Can you print nicely the error on stderr and exit with -1 rather than outputing a panic! ?
There was a problem hiding this comment.
That did for bin/cli_gen.rs , there is another file who need this modification? Like from cc_test
telamon-gen/src/lexer/ffi.rs
Outdated
| /// A F/lex's token with a span. | ||
| #[derive(Copy, Clone, Debug)] | ||
| #[repr(C)] | ||
| pub struct Span<Y> { |
There was a problem hiding this comment.
For cohenrency with libsyntax, call this Spanned. Span is the same structure but without the data field.
telamon-gen/src/lexer/mod.rs
Outdated
| UnexpectedToken(Position, Token, Position), | ||
| } | ||
|
|
||
| pub type Spanned<T, P, E> = Result<(P, T, P), E>; |
There was a problem hiding this comment.
No sure what is this type. Can you add documentation ?
telamon-utils/src/lib.rs
Outdated
| @@ -176,6 +176,17 @@ macro_rules! generated_file { | |||
| } | |||
| } | |||
|
|
|||
| /// Pulbic includes a generates file into the current file. | |||
| #[macro_export] | |||
| macro_rules! pub_generated_file { | |||
There was a problem hiding this comment.
Better have a single macro generated_file with two rules: ($name:ident) and (pub $name:ident).
telamon-gen/src/lib.rs
Outdated
| let mut input = fs::File::open(path::Path::new(input_path)).unwrap(); | ||
| let mut output = fs::File::create(path::Path::new(output_path)).unwrap(); | ||
| let input_path_str = input_path.to_string_lossy(); | ||
| info!("compiling {} to {}", input_path_str, output_path.to_string_lossy()); | ||
| process(&mut input, &mut output, format); | ||
| process(&mut input, &mut output, format) |
There was a problem hiding this comment.
I would prefere if the file name was stored alongside the position in the error. This way, we can use it on a Display implementation of the Error.
There was a problem hiding this comment.
That mean the process function should returns a type with a Error implementation? Mean, not a tuple like this aaf0a4ddb68afe687250a521941cc5df49010feb/telamon-gen/src/lib.rs#L66?
| @@ -1,35 +0,0 @@ | |||
| /// Function shared among examples. | |||
There was a problem hiding this comment.
Why have you changed this file ?
There was a problem hiding this comment.
Yes, that was moved to sgemm_low.rs because common.rs isn't a binary example
generated_file as (pub) macro; danielkeep.github.io/tlborm/book/pat-v…
|
When we will have more errors management, maybe we will have to consider another output style for ProcessError interface. |
