Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle query for slash window progress #1146

Closed
4 tasks
adamewozniak opened this issue Jul 20, 2022 · 1 comment · Fixed by #1147
Closed
4 tasks

Oracle query for slash window progress #1146

adamewozniak opened this issue Jul 20, 2022 · 1 comment · Fixed by #1147
Assignees
@adamewozniak
Labels
C:x/oracle

Comments

@adamewozniak
Copy link
Collaborator

adamewozniak commented Jul 20, 2022 •
edited
Loading

Summary

Problem Definition

The oracle module doesn't currently have any queries which show how far into a slash window we are. Validators could derive this by checking the oracle params, current block height, and doing some math, but it might be helpful to bake it into our queries.

Add a query which responds with the current voting period in the current slash window, so that validators can compare their miss counters.

This will be super helpful for diagnosing issues in upcoming testnets.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adamewozniak adamewozniak mentioned this issue Jul 20, 2022
Merged
17 tasks
@adamewozniak
Copy link
Collaborator Author

Maybe we could also add a query to return a validator's percentage of missed votes in the current slash window? Although that would be relatively easy for frontend to do, just validator's miss counter / slash window progress

@adamewozniak adamewozniak self-assigned this Jul 20, 2022
@mergify mergify bot closed this as completed in #1147 Jul 21, 2022
mergify bot pushed a commit that referenced this issue Jul 21, 2022
@adamewozniak
feat(oracle): add query & cli for slashing window progress (#1147)
069e145 
Adds an oracle query for slashing window progress

closes: #1146

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamewozniak adamewozniak

Labels
C:x/oracle
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(oracle): add query & cli for slashing window progress umee-network/umee
1 participant
@adamewozniak