Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidator must be incentivized to keep uTokens #1158

Closed
4 tasks
robert-zaremba opened this issue Jul 22, 2022 · 2 comments · Fixed by #1222
Closed
4 tasks

Liquidator must be incentivized to keep uTokens #1158

robert-zaremba opened this issue Jul 22, 2022 · 2 comments · Fixed by #1222

Comments

@robert-zaremba
Copy link
Member

Summary

In #1118 we allow liquidator to automatically receive the underlying token, instead of uToken.

The problem is that it removes the liquidity from the system, rather than incentivizing liquidator to keep the liquidity in the system

Proposal

  • Add one more global parameter to the system: UTokenLiquidationFee
  • Whenever liquidator will decide to automatically redeem uToken to the underlying token when doing a liquidation, his premium will be reduced by UTokenLiquidationFee. Basically the premium he will receive will equal to premium * (1-UTokenLiquidationFee)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@swisstackle
Copy link

swisstackle commented Jul 24, 2022

Wouldn't you only want to charge a fee if the collateral utilization is at it's max though? Otherwise it will be harder to have liquidators period - depending on how high the fee is.

Or maybe the higher the collateral utilization, the higher the fee?

@robert-zaremba
Copy link
Member Author

In general we want to have an small incenitve to keep the liquidity in the protocol.

For this use case I think the simple solution will work, and we can consider more complex solutions in the future. Feel free to make a full proposal.

@mergify mergify bot closed this as completed in #1222 Aug 10, 2022
mergify bot pushed a commit that referenced this issue Aug 10, 2022
## Description

- Adds proto for `DirectLiquidationFee` as well as actually implementing the behavior.

Misc additions:

- Moved token <-> uToken denom functions to `types` package. Previously there were similar functions in both `types` and `keeper`.
- Improved operations tests in simulation package and fixed a hidden bug (fees making messages fail if the random generator hit certain values, due to some transactions not using `CoinsSpentInMsg`)

closes: #1158 

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] added appropriate labels to the PR
- [x] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants