Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify negative time elapsed error #1012

Merged
merged 3 commits into from
Jun 8, 2022
Merged

chore: clarify negative time elapsed error #1012

merged 3 commits into from
Jun 8, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Jun 8, 2022

Description

Makes it easier to determine which times are responsible for #543 and similar


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki requested a review from a team as a code owner June 8, 2022 14:35
@toteki toteki requested a review from a team as a code owner June 8, 2022 14:36
@codecov-commenter
Copy link

Codecov Report

Merging #1012 (33ac25d) into main (bd2244f) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
- Coverage   43.96%   43.95%   -0.01%     
==========================================
  Files          64       64              
  Lines        8332     8331       -1     
==========================================
- Hits         3663     3662       -1     
  Misses       4414     4414              
  Partials      255      255              
Impacted Files Coverage Δ
x/leverage/keeper/interest.go 78.47% <33.33%> (-0.15%) ⬇️

@toteki toteki merged commit 650016f into main Jun 8, 2022
@toteki toteki deleted the adam/errmsg branch June 8, 2022 15:37
mergify bot pushed a commit that referenced this pull request Jun 8, 2022
* chore: clarify negative time elapsed error

* cl++

(cherry picked from commit 650016f)

# Conflicts:
#	CHANGELOG.md
toteki added a commit that referenced this pull request Jun 8, 2022
* chore: clarify negative time elapsed error (#1012)

* chore: clarify negative time elapsed error

* cl++

(cherry picked from commit 650016f)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

* newline++

Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants