Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove proto getters #1125

Merged
merged 2 commits into from
Jul 12, 2022
Merged

refactor: remove proto getters #1125

merged 2 commits into from
Jul 12, 2022

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Jul 12, 2022

Description

closes: #1114


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba requested a review from a team as a code owner July 12, 2022 16:19
@RafilxTenfen
Copy link
Contributor

RafilxTenfen commented Jul 12, 2022

Does this need to go to changelogs?

@toteki
Copy link
Member

toteki commented Jul 12, 2022

No changelog needed in my opinion since observable behavior is unaffected

@toteki toteki changed the title feat(oracle): remove proto getters chore(oracle): remove proto getters Jul 12, 2022
@toteki toteki changed the title chore(oracle): remove proto getters chore: remove proto getters Jul 12, 2022
@robert-zaremba
Copy link
Member Author

I will add changelog update

@toteki toteki changed the title chore: remove proto getters refactor: remove proto getters Jul 12, 2022
@toteki
Copy link
Member

toteki commented Jul 12, 2022

I added labels and changed type prefix to refactor (I had to go back and read the guide since my first thought was chore)

@robert-zaremba
Copy link
Member Author

Thanks for quick review!

@robert-zaremba
Copy link
Member Author

added labels

We don't need to add labels in PRs linked to issues. If PR is not linked to issue, then we can use it as a "task" by adding to a board - only then we need to add labels.

changed type prefix to refactor

Thanks, makes sense.

@codecov-commenter
Copy link

Codecov Report

Merging #1125 (637e39b) into main (c1a31c0) will not change coverage.
The diff coverage is 35.62%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1125   +/-   ##
=======================================
  Coverage   43.82%   43.82%           
=======================================
  Files          65       65           
  Lines        8393     8393           
=======================================
  Hits         3678     3678           
  Misses       4472     4472           
  Partials      243      243           
Impacted Files Coverage Δ
x/leverage/client/cli/tx.go 0.00% <0.00%> (ø)
x/leverage/keeper/msg_server.go 0.84% <0.00%> (ø)
x/leverage/types/tx.go 0.00% <0.00%> (ø)
x/leverage/types/codec.go 41.93% <50.00%> (ø)
x/leverage/simulation/operations.go 92.66% <90.69%> (ø)
x/leverage/client/tests/tests.go 100.00% <100.00%> (ø)
x/leverage/keeper/keeper.go 43.92% <100.00%> (ø)
x/leverage/keeper/validate.go 51.61% <100.00%> (ø)

@mergify mergify bot merged commit 3a77adf into main Jul 12, 2022
@mergify mergify bot deleted the robert/proto-getters branch July 12, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove getters from generated gogo code.
5 participants