Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proto)!: rename market size queries to total supplied #1140

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Jul 18, 2022

Description

closes: #1100


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #1140 (e93cb85) into main (6c9be69) will not change coverage.
The diff coverage is 19.67%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1140   +/-   ##
=======================================
  Coverage   43.82%   43.82%           
=======================================
  Files          65       65           
  Lines        8393     8393           
=======================================
  Hits         3678     3678           
  Misses       4472     4472           
  Partials      243      243           
Impacted Files Coverage Δ
x/leverage/client/cli/query.go 0.00% <0.00%> (ø)
x/leverage/keeper/grpc_query.go 5.67% <0.00%> (ø)
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/leverage/client/tests/tests.go 100.00% <100.00%> (ø)

@toteki toteki changed the title refactor!(proto): rename market size queries to total supplied chore!(proto): rename market size queries to total supplied Jul 18, 2022
@toteki toteki changed the title chore!(proto): rename market size queries to total supplied refactor(proto)!: rename market size queries to total supplied Jul 18, 2022
@toteki toteki marked this pull request as ready for review July 18, 2022 21:16
@toteki toteki requested review from a team as code owners July 18, 2022 21:16
@toteki toteki merged commit f7cb922 into main Jul 19, 2022
@toteki toteki deleted the adam/marketsize branch July 19, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/leverage: change MarketSize to TotalSupplied in queries
3 participants