feat(proto)!: Add MaxCollateralShare, MinCollateralLiquidity, MaxSupplyUtilization #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toteki
changed the title
17 tasks
Codecov Report
@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
- Coverage 44.13% 43.17% -0.97%
==========================================
Files 65 65
Lines 8367 8574 +207
==========================================
+ Hits 3693 3702 +9
- Misses 4430 4628 +198
Partials 244 244
|
17 tasks
toteki
commented
Jul 25, 2022
17 tasks
There was a problem hiding this comment.
We can easily use basis points instead of string. Let's firstly continue with #1149
| Blacklist bool | ||
| MaxCollateralShare sdk.Dec | ||
| MaxSupplyUtilization sdk.Dec | ||
| MinCollateralLiquidity sdk.Dec | ||
| } |
There was a problem hiding this comment.
instead of copying the structure, let's create a link to generated code. This way it will be easier to keep it in sync.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds proto and Token struct updates for three new Token fields
closes: #1095 #1036
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...