Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bad debt query #1238

Merged
merged 2 commits into from
Aug 11, 2022
Merged

feat: add bad debt query #1238

merged 2 commits into from
Aug 11, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Aug 11, 2022

Description

This query is something I wish I had when debugging umeemania liquidations - it will be useful in tracking the progress of bad debt repayment in situations where reserves are exhausted, and also provide a quick way to verify that repayment is working properly.

Note that when reserves are adequate and repayment is functioning, bad debts are repaid instantly in EndBlock, so the response will be empty most of the time.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

CHANGELOG.md Outdated Show resolved Hide resolved
@toteki toteki marked this pull request as ready for review August 11, 2022 17:52
@toteki toteki requested review from a team as code owners August 11, 2022 17:52
@codecov-commenter
Copy link

Codecov Report

Merging #1238 (a63a3bb) into main (8277b19) will decrease coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
- Coverage   50.95%   50.53%   -0.43%     
==========================================
  Files          67       67              
  Lines        6774     6831      +57     
==========================================
  Hits         3452     3452              
- Misses       3078     3135      +57     
  Partials      244      244              
Impacted Files Coverage Δ
x/leverage/keeper/grpc_query.go 60.69% <0.00%> (-2.95%) ⬇️
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)

@toteki toteki merged commit 4702557 into main Aug 11, 2022
@toteki toteki deleted the adam/debtquery branch August 11, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants