Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oracle): simplify window progress query #1294

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

adamewozniak
Copy link
Collaborator

Simplifies the math for the oracle window progress query.

This was one of those things, "wait, why did I do it that way?"


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@adamewozniak adamewozniak marked this pull request as ready for review August 26, 2022 18:29
@adamewozniak adamewozniak requested review from a team as code owners August 26, 2022 18:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #1294 (e19e8d9) into main (4bdbf52) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   51.39%   51.34%   -0.05%     
==========================================
  Files          68       68              
  Lines        6841     6834       -7     
==========================================
- Hits         3516     3509       -7     
  Misses       3067     3067              
  Partials      258      258              
Impacted Files Coverage Δ
x/oracle/types/query.pb.gw.go 0.00% <ø> (ø)
x/oracle/keeper/grpc_query.go 97.91% <100.00%> (-0.10%) ⬇️

@mergify mergify bot merged commit dbf5b89 into main Aug 26, 2022
@mergify mergify bot deleted the woz/refactor-window-progress-query branch August 26, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants