Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Interpret x/0 collateral liquidity as 100% #1357

Merged
merged 8 commits into from
Sep 8, 2022
Merged

fix: Interpret x/0 collateral liquidity as 100% #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
610d3df
fix 0/0 collateral liquidity
toteki Sep 8, 2022
52592e7
cl++
toteki Sep 8, 2022
5902320
Merge branch 'main' into adam/fix
toteki Sep 8, 2022
bad5dcf
Merge branch 'main' into adam/fix
khoerling Sep 8, 2022
767b3ab
Merge branch 'main' into adam/fix
khoerling Sep 8, 2022
902f665
comment++
toteki Sep 8, 2022
9ff4710
comment++
toteki Sep 8, 2022
87fb8e2
comment++
toteki Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
- [1018](https://github.com/umee-network/umee/pull/1018) Return nil if negative time elapsed from the last block happens.
- [1156](https://github.com/umee-network/umee/pull/1156) Propagate context correctly.
- [1288](https://github.com/umee-network/umee/pull/1288) Safeguards LastInterestTime against time reversals and unintended interest from hard forks.
- [1357](https://github.com/umee-network/umee/pull/1357) Interptex x/0 collateral liquidity as 100%

## [v2.0.2](https://github.com/umee-network/umee/releases/tag/v2.0.2) - 2022-05-13

Expand Down
7 changes: 5 additions & 2 deletions x/leverage/keeper/collateral.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,12 @@ func (k Keeper) CollateralLiquidity(ctx sdk.Context, denom string) sdk.Dec {
exchangeRate := k.DeriveExchangeRate(ctx, denom)
liquidity := k.AvailableLiquidity(ctx, denom)

// Zero collateral will be interpreted as having no liquidity
// Zero collateral will be interpreted as full collateral liquidity. This encompasses two cases:
// - liquidity / collateral = 0/0: Empty market, system is considered healthy by default
// - liquidity / collateral = x/0: No collateral but nonzero liquidity, also considered healthy
// In both cases, "all collateral is liquid" is technically true, given that there is no collateral.
if totalCollateral.IsZero() {
return sdk.ZeroDec()
return sdk.OneDec()
}

collateralLiquidity := toDec(liquidity).Quo(exchangeRate.MulInt(totalCollateral.Amount))
Expand Down