-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: liquidator query enabled by runtime flag #1577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid the global variables, especially if we modify them in tests, and even more especially if they are pointers.
Codecov Report
@@ Coverage Diff @@
## main #1577 +/- ##
==========================================
+ Coverage 52.08% 52.18% +0.10%
==========================================
Files 72 73 +1
Lines 7092 7105 +13
==========================================
+ Hits 3694 3708 +14
+ Misses 3125 3124 -1
Partials 273 273
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. LGTM.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Description
The query
liquidation-targets
is enabled at runtime the node is started with a flag:closes: #1400
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...