Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: incentive module proto #1630

Merged
merged 19 commits into from
Dec 7, 2022
Merged

feat: incentive module proto #1630

merged 19 commits into from
Dec 7, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Nov 30, 2022

Description

This PR has been extracted from #1514 to accelerate merging.

Changes since previous review:

  • Renamed BondAmount -> Bond since it contains sdk.Coin field
  • Added 4 additional queries PendingRewards(addr), Bonded(addr), TotalBonded(denom), and Unbondings(addr)
  • Removed the MsgGovCreateAndSponsorProgram that is still under debate - the separate MsgGovCreateProgram and permissionless MsgSponsor are included in this first version.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki marked this pull request as ready for review November 30, 2022 15:28
@toteki toteki requested a review from a team as a code owner November 30, 2022 15:28
@toteki toteki changed the title feat: incentive module prot feat: incentive module proto Nov 30, 2022
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good. Let's check in chat if we are good to release v1 with only one reward coin.

proto/umee/incentive/v1/genesis.proto Outdated Show resolved Hide resolved
proto/umee/incentive/v1/query.proto Outdated Show resolved Hide resolved
proto/umee/incentive/v1/query.proto Outdated Show resolved Hide resolved
proto/umee/incentive/v1/query.proto Outdated Show resolved Hide resolved
proto/umee/incentive/v1/tx.proto Show resolved Hide resolved
proto/umee/incentive/v1/tx.proto Show resolved Hide resolved
proto/umee/incentive/v1/tx.proto Show resolved Hide resolved
toteki and others added 8 commits December 1, 2022 08:33
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@toteki toteki requested a review from a team as a code owner December 5, 2022 20:13
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving.

  • let's specify what should happen with a proposal not funded by communify fund, and hanging out for long time (nobody will fund it). I suggest that we can remove it after some time (eg 1 or 2 months)?

proto/umee/incentive/v1/tx.proto Outdated Show resolved Hide resolved
proto/umee/incentive/v1/tx.proto Outdated Show resolved Hide resolved
proto/umee/incentive/v1/tx.proto Show resolved Hide resolved
proto/umee/incentive/v1/tx.proto Outdated Show resolved Hide resolved