-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: incentive module proto #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good. Let's check in chat if we are good to release v1 with only one reward coin.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
robert-zaremba
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approving.
- let's specify what should happen with a proposal not funded by communify fund, and hanging out for long time (nobody will fund it). I suggest that we can remove it after some time (eg 1 or 2 months)?
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Description
This PR has been extracted from #1514 to accelerate merging.
Changes since previous review:
BondAmount
->Bond
since it contains sdk.Coin fieldPendingRewards(addr)
,Bonded(addr)
,TotalBonded(denom)
, andUnbondings(addr)
MsgGovCreateAndSponsorProgram
that is still under debate - the separateMsgGovCreateProgram
and permissionlessMsgSponsor
are included in this first version.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...