-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add QueryMaxWithdraw and MsgWithdrawMax #1642
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1642 +/- ##
==========================================
+ Coverage 54.05% 54.17% +0.12%
==========================================
Files 71 71
Lines 7150 7483 +333
==========================================
+ Hits 3865 4054 +189
- Misses 2988 3115 +127
- Partials 297 314 +17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed the proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments to guide reviewers. Let's get this merged quickly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
This will make withdrawing 100% from frontend easier and less vulnerable to price and uToken exchange rate drift.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...