-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement incentive msg interface #1653
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1653 +/- ##
==========================================
+ Coverage 55.15% 55.29% +0.13%
==========================================
Files 73 73
Lines 7522 7503 -19
==========================================
Hits 4149 4149
+ Misses 3053 3034 -19
Partials 320 320
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you implement Route
and Type
methods for all messages , For Ledger support we need to implement this two methods
// Route implements the sdk.Msg interface.
func (m MsgType) Route() string { return types.RouterKey }
// Type implements the sdk.Msg interface.
func (m MsgType) Type() string { return sdk.MsgTypeURL(&m) }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This implements
Msg
interface for the incentive message types and also takes care of some supporting details (codec, errors, etc)It also moves
validateProposal
used in leverage toutil/checkers
, then reuses it for incentive proposals.Some
make proto-all
effects are also included (oracle formatting / swagger)