-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 4.1 BNB migration #1807
fix: 4.1 BNB migration #1807
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1807 +/- ##
==========================================
- Coverage 57.80% 57.62% -0.19%
==========================================
Files 78 79 +1
Lines 8023 8049 +26
==========================================
Hits 4638 4638
- Misses 3047 3073 +26
Partials 338 338
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the error code and github lints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid growing the keeper package.
This will switch the BNB ibc denom in the leverage registry and oracle accept list to the correct denom. (cherry picked from commit 0e4df51) # Conflicts: # app/upgrades.go # x/leverage/keeper/internal_test.go
* fix: 4.1 BNB migration (#1807) This will switch the BNB ibc denom in the leverage registry and oracle accept list to the correct denom. (cherry picked from commit 0e4df51) # Conflicts: # app/upgrades.go # x/leverage/keeper/internal_test.go * fix conficts --------- Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
This will switch the BNB ibc denom in the leverage registry and oracle accept list to the correct denom.