Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getting bonded validator power in oracle endblocker #1845

Merged
merged 5 commits into from
Feb 17, 2023

Conversation

rbajollari
Copy link
Contributor

Description


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

x/oracle/abci.go Fixed Show resolved Hide resolved
x/oracle/abci.go Fixed Show fixed Hide fixed
@rbajollari rbajollari marked this pull request as ready for review February 17, 2023 22:49
@rbajollari rbajollari requested review from a team as code owners February 17, 2023 22:49
@rbajollari rbajollari added this pull request to the merge queue Feb 17, 2023
Merged via the queue into main with commit c258acc Feb 17, 2023
@rbajollari rbajollari deleted the ryan/fix-val-power branch February 17, 2023 23:24
mergify bot pushed a commit that referenced this pull request Feb 17, 2023
* fix validator power

* Floating point math and unit test

* fix e2e

* CHANGELOG++

---------

Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
(cherry picked from commit c258acc)

# Conflicts:
#	tests/e2e/e2e_setup_test.go
#	tests/e2e/e2e_test.go
toteki pushed a commit that referenced this pull request Feb 18, 2023
) (#1848)

* fix: getting bonded validator power in oracle endblocker (#1845)

* fix validator power

* Floating point math and unit test

* fix e2e

* CHANGELOG++

---------

Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
(cherry picked from commit c258acc)

# Conflicts:
#	tests/e2e/e2e_setup_test.go
#	tests/e2e/e2e_test.go

* fix conflicts

---------

Co-authored-by: ryanbajollari <54822716+rbajollari@users.noreply.github.com>
Co-authored-by: rbajollari <rbajollari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants