-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ibc quota check enabled #1913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If we are doing it then let's handle all cases . For example in
SendPacket
- We should also add tests.
Codecov Report
@@ Coverage Diff @@
## main #1913 +/- ##
==========================================
- Coverage 68.09% 68.07% -0.02%
==========================================
Files 100 100
Lines 8017 8019 +2
==========================================
Hits 5459 5459
- Misses 2140 2142 +2
Partials 418 418
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add a task to add tests.
I added task for this https://linear.app/umee/issue/UMEE-486/add-tests-to-ibc-status-param-enabled-to-check-quota |
Description
closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...