Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ibc quota check enabled #1913

Merged
merged 14 commits into from
Apr 4, 2023
Merged

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Mar 14, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 requested a review from a team as a code owner March 14, 2023 13:59
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If we are doing it then let's handle all cases . For example in SendPacket
  2. We should also add tests.

@robert-zaremba robert-zaremba marked this pull request as draft March 14, 2023 16:48
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #1913 (ddfe8a9) into main (208d607) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
- Coverage   68.09%   68.07%   -0.02%     
==========================================
  Files         100      100              
  Lines        8017     8019       +2     
==========================================
  Hits         5459     5459              
- Misses       2140     2142       +2     
  Partials      418      418              
Impacted Files Coverage Δ
x/uibc/quota/keeper/relay.go 0.00% <0.00%> (ø)

@gsk967 gsk967 marked this pull request as ready for review March 23, 2023 13:28
@robert-zaremba robert-zaremba changed the title fix: checking quota if ibc quota check enabled fix: ibc quota check enabled Mar 27, 2023
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add a task to add tests.

x/uibc/quota/ibc_module.go Outdated Show resolved Hide resolved
@gsk967
Copy link
Collaborator Author

gsk967 commented Mar 28, 2023

  • add a task to add tests.

I added task for this https://linear.app/umee/issue/UMEE-486/add-tests-to-ibc-status-param-enabled-to-check-quota

@gsk967 gsk967 enabled auto-merge March 28, 2023 18:23
x/uibc/quota/keeper/relay.go Outdated Show resolved Hide resolved
@gsk967 gsk967 added this pull request to the merge queue Apr 4, 2023
@gsk967 gsk967 removed this pull request from the merge queue due to a manual request Apr 4, 2023
@gsk967 gsk967 enabled auto-merge April 4, 2023 15:18
@gsk967 gsk967 added this pull request to the merge queue Apr 4, 2023
Merged via the queue into main with commit 4826437 Apr 4, 2023
@gsk967 gsk967 deleted the sai/quota_check_if_quota_enabled_params branch April 4, 2023 15:36
@robert-zaremba robert-zaremba mentioned this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants