Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use DavidAnson/markdownlint #2009

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Apr 25, 2023

  1. we already lint go files with golangci-linter and proto files with proto linter
  2. we don't have other programming language
  3. whenever PR check pass, the super linter takes anther run (about 2min) in the merge queue (most of the time is the super linter setup time).

Diff in a normal flow (PR): 2min -> down to 20s

Let's optimize the linter job by using better action.

This PR also fixes:

  • outstanding dead links
  • default formatting issues (markdown config was not correctly check by the super-linter)

@robert-zaremba robert-zaremba requested a review from a team as a code owner April 25, 2023 19:09
@robert-zaremba robert-zaremba requested a review from a team as a code owner April 25, 2023 19:13
@toteki
Copy link
Member

toteki commented Apr 25, 2023

We can remove super linter from required statuses too

@robert-zaremba
Copy link
Member Author

yes, will do it, and change to markdown-lint

@robert-zaremba robert-zaremba added this pull request to the merge queue Apr 25, 2023
Merged via the queue into main with commit dd4937b Apr 25, 2023
@robert-zaremba robert-zaremba deleted the robert/markdown-linter branch April 25, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants