Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use generics to load a collection from store #2010

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Conversation

robert-zaremba
Copy link
Member

Description

@robert-zaremba robert-zaremba requested review from a team as code owners April 25, 2023 22:08
@robert-zaremba robert-zaremba requested a review from a team as a code owner April 25, 2023 22:11
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #2010 (f3cac6d) into main (7f05ad4) will decrease coverage by 6.81%.
The diff coverage is 44.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   75.38%   68.58%   -6.81%     
==========================================
  Files         100      116      +16     
  Lines        8025     9329    +1304     
==========================================
+ Hits         6050     6398     +348     
- Misses       1589     2453     +864     
- Partials      386      478      +92     
Impacted Files Coverage Δ
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/incentive/keeper/hooks.go 0.00% <0.00%> (ø)
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/keeper/incentive.go 0.00% <0.00%> (ø)
x/oracle/keeper/hooks.go 95.65% <ø> (ø)
x/incentive/keeper/genesis.go 1.61% <1.61%> (ø)
x/incentive/genesis.go 10.32% <3.70%> (-3.01%) ⬇️
x/incentive/keeper/iter.go 20.14% <7.76%> (ø)
... and 26 more

... and 1 file with indirect coverage changes

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsk967 gsk967 enabled auto-merge April 26, 2023 14:22
@gsk967 gsk967 added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit 1b94111 Apr 26, 2023
@gsk967 gsk967 deleted the robert/store-load branch April 26, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants