Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify util tsdk and store packages #2038

Merged
merged 3 commits into from
May 14, 2023
Merged

unify util tsdk and store packages #2038

merged 3 commits into from
May 14, 2023

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented May 13, 2023

Description

test/util/store.go and test/tsdk/store.go have duplicated functionality. This PR unifies them.
Once we will remove GB, the test/util package will be removed as well.

@robert-zaremba robert-zaremba requested review from a team as code owners May 13, 2023 18:54
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #2038 (ed33f9f) into main (7f05ad4) will decrease coverage by 7.96%.
The diff coverage is 47.14%.

❗ Current head ed33f9f differs from pull request most recent head b69a9d0. Consider uploading reports for the commit b69a9d0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2038      +/-   ##
==========================================
- Coverage   75.38%   67.43%   -7.96%     
==========================================
  Files         100      123      +23     
  Lines        8025     9434    +1409     
==========================================
+ Hits         6050     6362     +312     
- Misses       1589     2605    +1016     
- Partials      386      467      +81     
Impacted Files Coverage Δ
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/hooks.go 0.00% <0.00%> (ø)
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/keeper/incentive.go 0.00% <0.00%> (ø)
x/leverage/types/token.go 77.27% <ø> (ø)
x/oracle/keeper/hooks.go 95.65% <ø> (ø)
x/ugov/keeper/msg_server.go 0.00% <0.00%> (ø)
x/ugov/keeper/query_server.go 0.00% <0.00%> (ø)
x/uibc/quota/keeper/genesis.go 0.00% <0.00%> (-100.00%) ⬇️
... and 41 more

... and 2 files with indirect coverage changes

tests/tsdk/store.go Outdated Show resolved Hide resolved
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label May 13, 2023
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-zaremba robert-zaremba added this pull request to the merge queue May 14, 2023
Merged via the queue into main with commit 173ace9 May 14, 2023
@robert-zaremba robert-zaremba deleted the robert/tsdk branch May 14, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants